Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIU-3115 - reading room access accordion on user edit view #2694

Merged
merged 12 commits into from
May 24, 2024

Conversation

Terala-Priyanka
Copy link
Contributor

@Terala-Priyanka Terala-Priyanka commented May 21, 2024

Purpose

UIU-3115 - Changing Reading Room Access in User Record

Approach

Reading Room Access Accordion will be displayed on "User Edit View" when the interface "reading-room-patron-permission" is available and edit permisisons are available. (This interface is currently included in okapiInterfaces list and will be moved to optionalOkapiInterfaces very soon, in the scope of https://folio-org.atlassian.net/browse/UIU-3146)

Screencast

NkxtmGq1NB

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@Terala-Priyanka Terala-Priyanka marked this pull request as draft May 21, 2024 15:24
@Terala-Priyanka Terala-Priyanka self-assigned this May 21, 2024
@Terala-Priyanka Terala-Priyanka marked this pull request as ready for review May 22, 2024 09:39
@Terala-Priyanka Terala-Priyanka requested review from manvendra-s-rathore and a team and removed request for a team and manvendra-s-rathore May 22, 2024 09:43
@Terala-Priyanka Terala-Priyanka marked this pull request as draft May 22, 2024 10:09
@Terala-Priyanka Terala-Priyanka marked this pull request as ready for review May 22, 2024 11:46
@Terala-Priyanka Terala-Priyanka requested review from manvendra-s-rathore and a team May 22, 2024 11:46
},
};
console.log('mutator ', props.mutator);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this console log

Copy link

@Terala-Priyanka
Copy link
Contributor Author

@folio-org/fe-tl-reviewers
Please review this PR

@Terala-Priyanka Terala-Priyanka merged commit eb84b32 into master May 24, 2024
5 checks passed
@Terala-Priyanka Terala-Priyanka deleted the UIU-3115 branch May 24, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants